Skip to content

Stabilise extended profiles (now part of Matrix v1.16) #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 6, 2025
Merged

Stabilise extended profiles (now part of Matrix v1.16) #5013

merged 7 commits into from
Oct 6, 2025

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Sep 18, 2025 •
edited
Loading

Requires #5014
Part of the spec since v1.16

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@Half-Shot Half-Shot requested a review from a team as a code owner September 18, 2025 10:32
@Half-Shot Half-Shot requested review from dbkr and t3chguy September 18, 2025 10:32
t3chguy
t3chguy requested changes Sep 18, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js-sdk claims it doesn't support v1.16 so that would probably need fixing first https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/version-support.ts#L26

@Half-Shot
Copy link
Contributor Author

js-sdk claims it doesn't support v1.16 so that would probably need fixing first https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/version-support.ts#L26

Oh god :(

@Half-Shot Half-Shot added the T-Task Tasks for the team like planning label Sep 18, 2025
@Half-Shot Half-Shot mentioned this pull request Sep 18, 2025
Merged
5 tasks
@richvdh
Copy link
Member

richvdh commented Sep 29, 2025

js-sdk claims it doesn't support v1.16 so that would probably need fixing first develop/src/version-support.ts#L26

not sure that's correct? wouldn't it be the other way around: we must support the stable names before declaring support for 1.16?

@richvdh
Copy link
Member

richvdh commented Sep 29, 2025

cc @Half-Shot

@Half-Shot
Copy link
Contributor Author

I mean it's up to the policy of the team. I'd have thought we can opportunistically support bits of v1.16 without having to declare support for it or it's predecessors? What's the problem we foresee with doing that?

@Half-Shot Half-Shot requested a review from t3chguy October 6, 2025 12:10
@Half-Shot
Copy link
Contributor Author

SonarCloud is complaining but there isn't much to test here.

@Half-Shot Half-Shot added this pull request to the merge queue Oct 6, 2025
Merged via the queue into develop with commit e885ecf Oct 6, 2025
32 checks passed
@Half-Shot Half-Shot deleted the hs/stabilize-ext-profiles branch October 6, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

No one assigned

Labels

T-Task Tasks for the team like planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Half-Shot @richvdh @t3chguy